Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Matrix social icon #1203

Merged
merged 4 commits into from
Dec 6, 2023
Merged

Add Matrix social icon #1203

merged 4 commits into from
Dec 6, 2023

Conversation

orhun
Copy link
Contributor

@orhun orhun commented Dec 2, 2023

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Dec 2, 2023 •
edited
Loading

🦋 Changeset detected

Latest commit: 3605047

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@astrojs/starlight Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel Vercel
Copy link

vercel bot commented Dec 2, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
starlight ✅ Ready (Inspect) Visit Preview Dec 6, 2023 0:39am

@github-actions github-actions bot added the 🌟 core Changes to Starlight’s main package label Dec 2, 2023
@astrobot-houston
Copy link
Collaborator

Hello! Thank you for opening your first PR to Starlight! ✨

Here’s what will happen next:

  1. Our GitHub bots will run to check your changes.
    If they spot any issues you will see some error messages on this PR.
    Don’t hesitate to ask any questions if you’re not sure what these mean!

  2. In a few minutes, you’ll be able to see a preview of your changes on Vercel 🤩

  3. One or more of our maintainers will take a look and may ask you to make changes.
    We try to be responsive, but don’t worry if this takes a few days.

at-the-vr
at-the-vr approved these changes Dec 4, 2023
View reviewed changes
Copy link
Member

@at-the-vr at-the-vr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nicely Done, Matrix icon looks perfect here

@at-the-vr
Copy link
Member

bumping this up to reach Hideoo 😁

HiDeoo
HiDeoo approved these changes Dec 5, 2023
View reviewed changes
Copy link
Member

@HiDeoo HiDeoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution 🙌

Just tested locally and this looks great!

Once reviewed by Chris, we will wait for the next release to merge this as merging this will automatically update the documentation to mention that this new icon is available and we don't want to do that too early before the actual release 👍

ElianCodes
ElianCodes approved these changes Dec 5, 2023
View reviewed changes
Copy link
Member

@ElianCodes ElianCodes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking fancy!

@delucis delucis added the 🌟 patch Change that triggers a patch release label Dec 6, 2023
delucis
delucis approved these changes Dec 6, 2023
View reviewed changes
Copy link
Member

@delucis delucis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks again for this @orhun! Time to release the matrix 🥳

@delucis delucis merged commit 4601449 into withastro:main Dec 6, 2023
@astrobot-houston astrobot-houston mentioned this pull request Dec 6, 2023
Merged
@orhun
Copy link
Contributor Author

orhun commented Dec 7, 2023

We now have a Matrix icon on our website: https://ratatui.rs

Thanks everyone! 🧀

@HiDeoo
Copy link
Member

HiDeoo commented Dec 7, 2023

We now have a Matrix icon on our website: ratatui.rs

Thanks everyone! 🧀

Thanks you for your contribution 🙌 (and the Ratatui website looks amazing 🤩 )

HiDeoo added a commit to HiDeoo/starlight that referenced this pull request Dec 13, 2023
@HiDeoo
Merge branch 'main' into hd-feat-tabs-sync
e22902b 
* main: (440 commits)
  i18n(fr): update `getting-started.mdx` (withastro#1245)
  [ci] format
  docs(showcase): add csmos.space (withastro#1269)
  [ci] format
  docs: add SiteOne Crawler to showcase (withastro#1264)
  Fix formatting
  [ci] format
  docs(i18n): Add Indonesian translation for site search documentation (withastro#1250)
  i18n(es): fix typo (withastro#1246)
  i18n(ja): Update getting-started.mdx (withastro#1252)
  i18n(es): Update `getting-started.mdx` (withastro#1247)
  i18n(ko-KR): update `getting-started.mdx` (withastro#1248)
  Update upgrade instructions to show new `@astrojs/upgrade` (withastro#1241)
  [ci] format
  [ci] release (withastro#1240)
  i18n(ru): Fix typo in `i18n.untranslatedContent` (withastro#1243)
  Fix timezone-reliance in LastUpdated (withastro#1170)
  Prefetch links on hover by default (withastro#1242)
  Add support for Astro v4, drop support for Astro v3 (withastro#1238)
  Add Matrix social icon (withastro#1203)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@at-the-vr at-the-vr at-the-vr approved these changes

@delucis delucis delucis approved these changes

@HiDeoo HiDeoo HiDeoo approved these changes

@ElianCodes ElianCodes ElianCodes approved these changes

Assignees
No one assigned
Labels
🌟 core Changes to Starlight’s main package 🌟 patch Change that triggers a patch release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@orhun @astrobot-houston @at-the-vr @HiDeoo @delucis @ElianCodes